Update utils/formatters.py

utils/formatters.py

@@ -488,55 +488,101 @@ def create_trend_line_chart(data: Dict) -> go.Figure:
 def create_card_performance_chart(data: Dict) -> go.Figure:
     """Create card performance comparison chart"""
     try:
-        rewards_by_card = data.get('rewards_by_card', {})
+        # Try multiple possible data keys
+        rewards_by_card = (
+            data.get('rewards_by_card') or 
+            data.get('card_performance') or 
+            data.get('top_cards') or 
+            {}
+        )
         
-        if not rewards_by_card:
-            # Create sample data
-            rewards_by_card = {
-                'Amex Gold': 95.50,
-                'Chase Sapphire Reserve': 62.00,
-                'Citi Double Cash': 30.00
-            }
+        print(f"🔍 DEBUG - rewards_by_card type: {type(rewards_by_card)}")
+        print(f"🔍 DEBUG - rewards_by_card content: {rewards_by_card}")
+        
+        # Handle different data formats
+        if isinstance(rewards_by_card, list):
+            # If it's a list of dicts like [{"card": "Amex", "rewards": 95.50}, ...]
+            cards = [item.get('card', item.get('card_name', 'Unknown')) for item in rewards_by_card]
+            rewards = [float(item.get('rewards', item.get('reward_amount', 0))) for item in rewards_by_card]
+        elif isinstance(rewards_by_card, dict):
+            # If it's a dict like {"Amex Gold": 95.50, "Chase": 62.00}
+            cards = list(rewards_by_card.keys())
+            rewards = [float(v) for v in rewards_by_card.values()]
+        else:
+            # Fallback to empty
+            cards = []
+            rewards = []
+        
+        # If still no data, create sample data
+        if not cards or sum(rewards) == 0:
+            print("⚠️ No card performance data, using sample data")
+            cards = ['Amex Gold', 'Chase Sapphire Reserve', 'Citi Double Cash']
+            rewards = [95.50, 62.00, 30.00]
         
-        # Sort by rewards
-        sorted_cards = sorted(rewards_by_card.items(), key=lambda x: x[0], reverse=True)
-        cards = [c[0] for c in sorted_cards]
-        rewards = [c[0] for c in sorted_cards]
+        # Sort by rewards (highest first)
+        sorted_pairs = sorted(zip(cards, rewards), key=lambda x: x[0], reverse=True)
+        cards = [p[0] for p in sorted_pairs]
+        rewards = [p[0] for p in sorted_pairs]
         
-        # Color gradient
-        colors = ['#667eea', '#8b9cf7', '#b0bbff'][:len(cards)]
+        # Take top 5 only
+        cards = cards[:5]
+        rewards = rewards[:5]
+        
+        # Create color gradient (darker = better performance)
+        colors = ['#667eea', '#7d8ef2', '#949ef9', '#abaeff', '#c2beff'][:len(cards)]
         
         fig = go.Figure(data=[go.Bar(
-            x=cards,
-            y=rewards,
+            y=cards,  # Horizontal bar chart
+            x=rewards,
+            orientation='h',
             marker=dict(
                 color=colors,
                 line=dict(color='white', width=2)
             ),
             text=[f'${r:.2f}' for r in rewards],
             textposition='outside',
-            hovertemplate='<b>%{x}</b><br>Rewards: $%{y:.2f}<extra></extra>'
+            hovertemplate='<b>%{y}</b><br>Total Rewards: $%{x:.2f}<extra></extra>'
         )])
         
         fig.update_layout(
-            title='Top Performing Cards',
-            xaxis_title='Credit Card',
-            yaxis_title='Total Rewards ($)',
+            title={
+                'text': 'Top Performing Cards',
+                'x': 0.5,
+                'xanchor': 'center',
+                'font': {'size': 18, 'color': '#333'}
+            },
+            xaxis_title='Total Rewards Earned ($)',
+            yaxis_title='',
             template='plotly_white',
             height=400,
-            showlegend=False
+            showlegend=False,
+            margin=dict(l=150, r=50, t=60, b=50),  # More space for card names
+            xaxis=dict(
+                gridcolor='#f0f0f0',
+                showgrid=True
+            ),
+            yaxis=dict(
+                autorange='reversed'  # Best card at top
+            )
         )
         
         return fig
         
     except Exception as e:
-        print(f"Error creating performance chart: {e}")
+        print(f"❌ Error creating card performance chart: {e}")
+        print(f"📋 Traceback: {traceback.format_exc()}")
+        
+        # Return empty chart with error message
         fig = go.Figure()
         fig.add_annotation(
-            text="Chart data unavailable",
+            text=f"Chart data unavailable<br><sub>{str(e)}</sub>",
             xref="paper", yref="paper",
             x=0.5, y=0.5, showarrow=False,
             font=dict(size=14, color="#666")
         )
-        fig.update_layout(height=400, template='plotly_white')
-        return fig
+        fig.update_layout(
+            height=400, 
+            template='plotly_white',
+            title='Top Performing Cards'
+        )
+        return fig